Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added LoginRadius Swags #169

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Added LoginRadius Swags #169

merged 4 commits into from
Oct 15, 2020

Conversation

ashish8947
Copy link
Contributor

  • I've read the Contributing.md file
  • I do not intend to make low-value changes, just for swag. I am aware, that my PR could otherwise be flagged as spam or invalid and may lead to a permanent exclusion from the Hacktoberfest event.

Adding a new Hacktoberfest participant

  • I did not edit the README.md file by hand
  • I made sure, that the new participant has not already been added
  • I'm not adding a company from the blocklist

Editing an existing Hacktoberfest participant

  • I did not edit the README.md file by hand
  • I made proper changes to the existing participant.yml file

@SoftCreatR SoftCreatR self-requested a review October 15, 2020 12:11
SoftCreatR
SoftCreatR requested changes Oct 15, 2020
View reviewed changes
Copy link
Collaborator

@SoftCreatR SoftCreatR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just edit the existing file.

@ashish8947
Copy link
Contributor Author

@SoftCreatR
What should I edit in the same? Can you explain it a bit more?

@SoftCreatR
Copy link
Collaborator

@SoftCreatR
What should I edit in the same? Can you explain it a bit more?

A file named loginradius.yml already exists. Just edit that one, rather than creating a new one under a different name.

@SoftCreatR SoftCreatR added enhancement New feature or request good first issue Good for newcomers hacktoberfest Qualifies for Hacktoberfest labels Oct 15, 2020
@SoftCreatR SoftCreatR merged commit 4b06be4 into benbarth:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoftCreatR SoftCreatR SoftCreatR approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Qualifies for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashish8947 @SoftCreatR